Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github: replace pingcap/ticdc with pingcap/tiflow in workflow #3965

Merged
merged 2 commits into from
Dec 20, 2021
Merged

github: replace pingcap/ticdc with pingcap/tiflow in workflow #3965

merged 2 commits into from
Dec 20, 2021

Conversation

amyangfei
Copy link
Contributor

@amyangfei amyangfei commented Dec 18, 2021 •
edited
Loading

What problem does this PR solve?

Some remaining pingcap/ticdc, finished the remaining problem-2 in #3749

The DM github action tests are verified in #3966.

These files were introduced from v5.3.0, so cherry pick to release-5.3 is enough.

What is changed and how it works?

replace pingcap/ticdc with pingcap/tiflow in files from .github dir

Check List

Tests

  • Unit test
  • Integration test
None

@amyangfei amyangfei added the needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. label Dec 18, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 18, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lance6716
  • lonng

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 18, 2021
@amyangfei amyangfei added the status/ptal Could you please take a look? label Dec 18, 2021
@amyangfei
Copy link
Contributor Author

/run-all-tests

@amyangfei amyangfei mentioned this pull request Dec 18, 2021
Closed
@amyangfei
Copy link
Contributor Author

/run-dm-integration-test

lance6716
lance6716 approved these changes Dec 18, 2021
View reviewed changes
Copy link
Contributor

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do this also has a script to make changes so we can replay the script to our PR?

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 18, 2021
@amyangfei amyangfei mentioned this pull request Dec 20, 2021
Closed
10 tasks
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 20, 2021
@amyangfei
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3b42676

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 20, 2021
@ti-chi-bot
Copy link
Member

@amyangfei: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@amyangfei
Copy link
Contributor Author

/run-leak-test

@ti-chi-bot ti-chi-bot merged commit 5ecb465 into pingcap:master Dec 20, 2021
@amyangfei amyangfei deleted the replace-remaining-pingcap-ticdc branch December 20, 2021 05:42
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Dec 20, 2021
@amyangfei @ti-chi-bot
This is an automated cherry-pick of pingcap#3965
abb49fc 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 20, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3976.

amyangfei added a commit to ti-chi-bot/tiflow that referenced this pull request Dec 20, 2021
@amyangfei
github: replace pingcap/ticdc with pingcap/tiflow in workflow (pingca…
136321c 
…p#3965)
zhaoxinyu pushed a commit to zhaoxinyu/ticdc that referenced this pull request Dec 29, 2021
@amyangfei @zhaoxinyu
github: replace pingcap/ticdc with pingcap/tiflow in workflow (pingca…
d1eb8b0 
…p#3965)
ti-chi-bot added a commit that referenced this pull request Feb 18, 2022
@ti-chi-bot
github: replace pingcap/ticdc with pingcap/tiflow in workflow (#3965) (…
f8de43e 
…#3976)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance6716 lance6716 lance6716 approved these changes

@lonng lonng lonng approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look?
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amyangfei @ti-chi-bot @lonng @lance6716